Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unflake RetryOnInvalidatedSessionTest #3561

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Dec 16, 2024

Tries to unflake the RetryOnInvalidatedSessionTest. The setup logic was wrong, potentially causing a Spanner instance to be created with the wrong options, which again could cause tests to fail.

Fixes #3557

@olavloite olavloite requested a review from a team as a code owner December 16, 2024 16:32
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 16, 2024
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2024
@olavloite olavloite merged commit 430143c into main Dec 16, 2024
34 checks passed
@olavloite olavloite deleted the unflake-retry-on-invalidated-session-test branch December 16, 2024 17:00
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2024
surbhigarg92 pushed a commit to surbhigarg92/java-spanner that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RetryOnInvalidatedSessionTest.asyncRunnerReadRow is flaky
2 participants